Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audio worklet import #143

Merged
merged 9 commits into from
Dec 23, 2024
Merged

Fix audio worklet import #143

merged 9 commits into from
Dec 23, 2024

Conversation

b-ma
Copy link
Collaborator

@b-ma b-ma commented Dec 21, 2024 •
edited
Loading

Todos:

  • use real module import instead Function to eval worklet processor
  • ensure WASM support
  • resolve AudioWorklet installed in node_modules
  • properly handle 'node-web-audio-api:worklet:ctor-error' message
  • improve error handling from AudioWorkletGlobalScope: stack trace, etc.

@b-ma b-ma changed the title Fix/audio worklet import Fix audio worklet import Dec 21, 2024
@b-ma
Copy link
Collaborator Author

b-ma commented Dec 21, 2024

wpt results:

  RESULTS:
  - # pass: 7348
  - # fail: 492
  - # type error issues: 3

@b-ma b-ma merged commit 0cfaa14 into main Dec 23, 2024
5 checks passed
@b-ma b-ma deleted the fix/audio-worklet-import branch December 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@b-ma